Skip to content

Conversation

@drish
Copy link
Collaborator

@drish drish commented Jan 19, 2026

Summary by cubic

Documented and tested support for sending or scheduling broadcasts via Broadcasts.create using send: true and optional scheduled_at. This clarifies correct usage and verifies both paths.

  • New Features
    • Broadcasts.create accepts send: true to send immediately.
    • scheduled_at is supported only when send: true is provided; using it alone is an error (documented).
    • Added specs covering immediate send and scheduled send.

Written for commit 7b3c15b. Summary will update on new commits.

@drish drish requested a review from Cisneiros January 19, 2026 18:42
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="spec/broadcasts_spec.rb">

<violation number="1" location="spec/broadcasts_spec.rb:46">
P2: Rule violated: **No `should` in tests**

Test descriptions must not include “should” per the “No `should` in tests” rule. Use a direct, declarative phrasing instead.</violation>

<violation number="2" location="spec/broadcasts_spec.rb:55">
P1: Rule violated: **API Key Permission Check SDK Methods**

The new tests introduce Resend broadcast sending/scheduling via `send: true` and `scheduled_at`, which are new SDK features. Per the “API Key Permission Check SDK Methods” rule, remind the author to confirm production API keys have the required permissions for sending/scheduling broadcasts to avoid permission failures after deployment.</violation>

<violation number="3" location="spec/broadcasts_spec.rb:61">
P2: Rule violated: **No `should` in tests**

Test descriptions must not include “should” per the “No `should` in tests” rule. Use a direct, declarative phrasing instead.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@drish drish merged commit a60e99b into main Jan 21, 2026
10 checks passed
@drish drish deleted the feat/broadcasts-send-scheduled-at branch January 21, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants