This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Support dot-separated addresses #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
please rebase |
Contributor
Author
|
@resmo |
resmo
reviewed
Mar 16, 2018
| if DEBUG: | ||
| log('%s is not a number' % part) | ||
| self.handle_self(qname) | ||
| return |
Contributor
Author
Doqnach
suggested changes
Apr 20, 2018
src/nip.py
Outdated
| subdomain = qname[0:qname.find(self.domain) - 1] | ||
| # Split foo.bar.10-0-0-1 in parts | ||
| subdomain_parts = subdomain.split('.') | ||
| match = re.findall('^(?:.+\.)?(\d{1,3}[-.]\d{1,3}[-.]\d{1,3}[-.]\d{1,3})$', subdomain) |
There was a problem hiding this comment.
I would suggest supporting either - or . but not both at the same time. This could be done using back-references: ^(?:.+\.)?(\d{1,3}([-.])\d{1,3}\2\d{1,3}\2\d{1,3})$ https://regex101.com/r/Tamzd5/2
There was a problem hiding this comment.
I would love to, but I will be very honest in saying that I have no idea how to and neither do I have any way of testing the change before creating a PR.
Contributor
Author
Match eather `-` or `.` but not both at the same time.
Contributor
Author
|
Thank you for your comments. |
Owner
|
Thanks! |
Contributor
Author
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports of dot-separated addresses like xip.io.