Prepare for resque 3.0 compatibility#809
Merged
PatrickTulskie merged 8 commits intoresque:masterfrom Jan 15, 2026
Merged
Conversation
Member
Author
|
Flipping this over to draft for now. I'll mark it ready for review once resque 3.0 is shipped. |
PatrickTulskie
force-pushed
the
prepare-v5
branch
10 times, most recently
from
aa5d6cf to
785a58a
Compare
- Update Ruby requirement to >= 3.0.0 - Update resque dependency to >= 3.0 - Update redis dependency to >= 4.0 - Add base64 runtime dependency for Ruby 3.4+ compatibility - Remove rack < 3 constraint from dev dependencies - Add Rack version matrix support with rackup for Rack 3+
- Update rubocop dependency to ~> 0.80 - Switch .rubocop.yml to DisabledByDefault approach with minimal enabled cops - Add scheduler.rb to GuardClause exclusions in .rubocop_todo.yml
IRB is no longer bundled with Ruby 4+ and must be explicitly declared as a development dependency.
- Remove Ruby 2.x support, test Ruby 3.0-3.4 + head only - Simplify resque matrix to test against master only - Update redis matrix to 4.8 and latest - Add Rack 2/3 matrix testing - Update rubocop workflow to use Ruby 3.4
- Change expected host from example.org to localhost in resque-web tests - Add default_host method override in test helper for Rack 3 compatibility
- Use JSON.parse instead of JSON.load - Use URI.decode_www_form_component instead of CGI.unescape
PatrickTulskie
force-pushed
the
prepare-v5
branch
from
785a58a to
c31bfe6
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares resque-scheduler for compatibility with resque 3.0.
Breaking Changes
>= 2.3.0→>= 3.0.0>= 1.27→>= 3.0>= 3.3→>= 4.0Dependencies
base64 ~> 0.1runtime dependency (Ruby 3.4+ compatibility)irbdev dependency (Ruby 4+ compatibility)rack < 3constraint, added Rack 2/3 matrix testing~> 0.40.0→~> 0.80CI/Testing
Code Improvements
JSON.parseinstead ofJSON.load(security improvement)URI.decode_www_form_componentinstead ofCGI.unescapeConfiguration
.rubocop.ymltoDisabledByDefault: trueapproachTargetRubyVersion: 3.0Note
This PR does not include a version bump to 5.0.0 yet. That will happen when resque 3.0 is released.