Fix finding the start and end of the current query.#239
Merged
NTBBloodbath merged 1 commit intorest-nvim:mainfrom Oct 27, 2023
PhilRunninger:fix-query-selection
Merged
Fix finding the start and end of the current query.#239NTBBloodbath merged 1 commit intorest-nvim:mainfrom PhilRunninger:fix-query-selection
NTBBloodbath merged 1 commit intorest-nvim:mainfrom
PhilRunninger:fix-query-selection
Conversation
1. start_request was searching forward from the cursor position. Adding 'b' to the search flags fixed that. 2. Both start_request and end_request depended on the user having set 'nowrapscan' to prevent wrapping around the end of the file. Such wrapping could result in finding the wrong query. Adding 'W' to the search flags fixed that, and removed the need for the stopline parameter. 3. Refactored the way last_line is used in end_request.
NTBBloodbath
approved these changes
Oct 27, 2023
Member
NTBBloodbath
left a comment
NTBBloodbath
left a comment
There was a problem hiding this comment.
Thank you so much for this patch. It is indeed a great solution in the meantime :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173.
This isn't a treesitter solution, but it's at least a quick and easy, if only temporary, patch.