Highlight request on run() and last()#60
Merged
jens1205 merged 11 commits intorest-nvim:mainfrom Aug 31, 2021
Merged
Conversation
highlight -> has to be fixed
… lazy-loading. Closes rest-nvim#30
NTBBloodbath
requested changes
Aug 30, 2021
Member
NTBBloodbath
left a comment
NTBBloodbath
left a comment
There was a problem hiding this comment.
Looking really good man, thank you for doing this!
I don't have any objection haha, but found some checks to == true that makes no sense imo since the conditionals implicitly do this but didn't wanted to be an ass and request a ton of changes for all of them so you know, just change it and feel free to merge. Awesome job man, thanks for contributing!
NTBBloodbath
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature "highlight request on run() and last()". In order to implement this, we had to switch from synchronous call to plenary-curl to asynchronous with callback. Implementation is similar to the build-in
vim.highlight.on_yank. This feature is enabled by default.Additionally, the old feature of moving the cursor to the current request line is disabled by default as the highlighting shows more accurate what is send and in my opinion it is nicer to have the cursor stay in place.
@NTBBloodbath : Any objections?