Update default config in EC2 construct for Restate 1.3.0#73
Merged
Conversation
Collaborator
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for updating the cdk construct @pcholakov. Is it possible to not set the roles explicitly? Otherwise, we will have a bit of trouble when splitting the http ingress from the worker role.
Comment on lines
356
to
361
| `roles = [`, | ||
| ` "worker",`, | ||
| ` "admin",`, | ||
| ` "metadata-store",`, | ||
| ` "metadata-server",`, | ||
| ` "log-server",`, | ||
| `]`, |
Collaborator
There was a problem hiding this comment.
Can we not set the roles explicitly? Otherwise it's gonna be problematic once we enable the http-ingress role by default because then this deployment won't run the ingress once we release 1.4.0.
Collaborator
Author
There was a problem hiding this comment.
That's a reasonable thing to do! I'll update for the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the default baseline restate-server config deployed by the EC2 construct to the following:
This fixes #72