style: simplify some statements for readability#2371
Merged
tillrohrmann merged 2 commits intorestatedev:mainfrom Nov 28, 2024
hamirmahal:style/simplify-some-statements-for-readability
Merged
style: simplify some statements for readability#2371tillrohrmann merged 2 commits intorestatedev:mainfrom hamirmahal:style/simplify-some-statements-for-readability
tillrohrmann merged 2 commits intorestatedev:mainfrom
hamirmahal:style/simplify-some-statements-for-readability
Conversation
hamirmahal
commented
Nov 27, 2024
Contributor
Author
hamirmahal
left a comment
hamirmahal
left a comment
There was a problem hiding this comment.
This shouldn't cause any user-facing changes. The goal here is to improve code readability and developer productivity.
tillrohrmann
approved these changes
Nov 27, 2024
Contributor
There was a problem hiding this comment.
Thanks for simplify the format and println statements @hamirmahal. The changes look good to me. Merging it after GHA gives green light :-)
Contributor
Author
|
You’re welcome, @tillrohrmann! I’m happy to help. |
hamirmahal
deleted the
style/simplify-some-statements-for-readability
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2370