Fix bifrost_append_and_seal_concurrent test instability#2887
Merged
tillrohrmann merged 1 commit intorestatedev:mainfrom Mar 11, 2025
Merged
Fix bifrost_append_and_seal_concurrent test instability#2887tillrohrmann merged 1 commit intorestatedev:mainfrom
tillrohrmann merged 1 commit intorestatedev:mainfrom
Conversation
The problem was that aborting the sealer task could leave the system in a state where the last loglet was sealed but no reconfiguration has happened. The problem is fixed by always letting the seal_and_extend_chain call complete. This fixes restatedev#2885.
jackkleeman
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that aborting the sealer task could leave the system in a state where the last loglet was sealed but no reconfiguration has happened. The problem is fixed by always letting the seal_and_extend_chain call complete.
This fixes #2885.