Record creation and modification timestamp in InvocationStatus#415
Closed
tillrohrmann wants to merge 2 commits intorestatedev:mainfrom
tillrohrmann:issue#290
Closed
Record creation and modification timestamp in InvocationStatus#415tillrohrmann wants to merge 2 commits intorestatedev:mainfrom tillrohrmann:issue#290
tillrohrmann wants to merge 2 commits intorestatedev:mainfrom
tillrohrmann:issue#290
Conversation
This commit adds tracking of the creation and last modification time of an ongoing invocation. This fixes #290.
Contributor
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
Just as a side comment (don't need to fix this now), it might be useful to put as part of the effects log (even better, parent span generated in the effects module) the creation time, modification time or just modification time - creation time
Contributor
Author
Yes, let's tackle this as a follow up since we currently don't have all the information in the effects module where the parent span is generated. I've created #417 for tracking this effort. |
slinkydeveloper
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds tracking of the creation and last modification time of an ongoing invocation.
This fixes #290.