[minor] Use SemanticRestateVersion instead of semver in ClusterMarker#4178
Merged
AhmedSoliman merged 2 commits intomainfrom Jan 13, 2026
Merged
[minor] Use SemanticRestateVersion instead of semver in ClusterMarker#4178AhmedSoliman merged 2 commits intomainfrom
AhmedSoliman merged 2 commits intomainfrom
Conversation
Test Results 7 files + 2 7 suites +2 3m 6s ⏱️ + 1m 49s Results for commit 781b41a. ± Comparison against base commit 96bd772. This pull request removes 34 and adds 47 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Adds support for HLC timestamps and extended headers in the record format for both log-server and local_loglet storage layers. Note that in this commit we don't actually write the HLC timestamp nor the extended header, but we handle decoding them correctly for forward compatibility. Additionally, the new flag for ExtendedHeader allows arbitrary header fields to be added (based on flags) in the future. Fixes #4149 - Add RecordFlags bitflags with HlcTimestamp and ExtendedHeader flags - Decode HLC timestamps (UniqueTimestamp) when HlcTimestamp flag is set - Skip extended header bytes when ExtendedHeader flag is set (forward compat) - Add test cases for decoding records with various flag combinations - Fix missing ExtendedHeader handling in bifrost decode_custom_encoded_record
Using our existing abstractions, fully compatible with semver::Version.
tillrohrmann
approved these changes
Jan 13, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for making our code base more uniform @AhmedSoliman. LGTM. +1 for merging :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using our existing abstractions, fully compatible with semver::Version.
Stack created with Sapling. Best reviewed with ReviewStack.