Set default in memory timer limit to 1024

[tillrohrmann]

This fixes #386.

[tillrohrmann]

One thing I couldn't figure out is how to set the limit to None when using the environment variables. With the restate.yaml one can set num_timers_in_memory_limit: null and it will disable the limit. Maybe we need to provide a custom deserializer that can understand None.

[slinkydeveloper]

@tillrohrmann IMO null is probably the right way, and perhaps the one that is more idiomatic in json, given there is no concept of Option and None

[slinkydeveloper]

I really need to build a macro for configuring those default values :(

[tillrohrmann]

@tillrohrmann IMO null is probably the right way, and perhaps the one that is more idiomatic in json, given there is no concept of Option and None

null only works with the restate.yaml. When setting it via the env variable it leads to a failure where null string is not a valid usize :-(

[slinkydeveloper]

When setting it via the env variable it leads to a failure where null string is not a valid usize

Perhaps just use export ENV_NAME so the value is empty? But yeah perhaps figment should accept null here.

[tillrohrmann]

When setting it via the env variable it leads to a failure where null string is not a valid usize

Perhaps just use export ENV_NAME so the value is empty? But yeah perhaps figment should accept null here.

One cannot export an empty env variable as far as I know (at least it is not working in my env).

[slinkydeveloper]

But an empty one yes?

!10755 ➜ export MY_ENV_NAME=""                                           
!10756 ➜ echo ${MY_ENV_NAME-nonexistent}                             

!10757 ➜ echo ${UNKNOWN-nonexistent}                          
nonexistent

[tillrohrmann]

But an empty one yes?

!10755 ➜ export MY_ENV_NAME=""                                           
!10756 ➜ echo ${MY_ENV_NAME-nonexistent}                             

!10757 ➜ echo ${UNKNOWN-nonexistent}                          
nonexistent

Does not work either because an empty string won't be detected as an Empty value. Same error that string was found but usize was expected.

[slinkydeveloper]

Does not work either because an empty string won't be detected as an Empty value. Same error that string was found but usize was expected.

Ah dammit, then open an issue about this and I'll take a look.

[tillrohrmann]

Here is the ticket: #478