Skip to content

Run e2e tests in CI#481

Merged
jackkleeman merged 6 commits intorestatedev:mainfrom
jackkleeman:upload-artifact
Jun 8, 2023
Merged

Run e2e tests in CI#481
jackkleeman merged 6 commits intorestatedev:mainfrom
jackkleeman:upload-artifact

Conversation

@jackkleeman
Copy link
Copy Markdown
Contributor

@jackkleeman jackkleeman commented Jun 2, 2023

  • Upload binary with 1 day retention; so it can be used in e2e jobs
  • Cross repo workflow call to e2e repo

As part of restatedev/e2e#110

Fixes #454

@jackkleeman jackkleeman requested a review from tillrohrmann June 2, 2023 12:53
@tillrohrmann
Copy link
Copy Markdown
Contributor

What's the plan wrt #460? Will the docker build step be replaced by downloading the binary and creating a docker image from it? Maybe this could also be part of this PR to give it more context.

cc @slinkydeveloper.

@jackkleeman
Copy link
Copy Markdown
Contributor Author

Yes, that is basically the plan, except it happens inside the e2e repo's workflow, not here. Here I just need to upload the artifact. Once that is working, I can set up the workflow call into the e2e repo

@jackkleeman
Copy link
Copy Markdown
Contributor Author

I think #460 wouldnt be needed, just the cross repo workflow call

@slinkydeveloper
Copy link
Copy Markdown
Contributor

I've no strong opinion on how to implement the e2e testing process, but i would like to have something merged very soon as it gives us more confidence on the overall stability. @jackkleeman if you think you'll have something ready soon, then let's close #460, otherwise i suggest we merge #460 and revert it once we have the more proper reusable workflow solution. WDYT?

@jackkleeman
Copy link
Copy Markdown
Contributor Author

@slinkydeveloper i hope to have it working today

@jackkleeman jackkleeman changed the title Build release binary as workflow artifact Run e2e tests in CI Jun 5, 2023
Copy link
Copy Markdown
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @jackkleeman. LGTM. +1 for merging once the required PR in the e2e repo has been merged.

With 1 day retention; so it can be used in e2e jobs
libc versions currently match docker; let's keep it that way
@jackkleeman jackkleeman merged commit bd218fd into restatedev:main Jun 8, 2023
@jackkleeman jackkleeman deleted the upload-artifact branch June 8, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run e2e tests as part of runtime release

3 participants