Upload artifact directly for e2e tests#491
Merged
jackkleeman merged 2 commits intorestatedev:mainfrom Jun 9, 2023
jackkleeman:upload-artifact-docker
Merged
Upload artifact directly for e2e tests#491jackkleeman merged 2 commits intorestatedev:mainfrom jackkleeman:upload-artifact-docker
jackkleeman merged 2 commits intorestatedev:mainfrom
jackkleeman:upload-artifact-docker
Conversation
jackkleeman
changed the title
jackkleeman
requested review from
slinkydeveloper and
tillrohrmann
and removed request for
tillrohrmann
slinkydeveloper
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we use the release binary, and it can actually run in parallel to the build and test ci job. The docker build seems to complete before the build and test is done anyway, so this will be slightly faster. Plus the e2es will run faster on release build.