envelope-v2: Move ingestion to use V2#4980
Conversation
Test Results 8 files ±0 8 suites ±0 2m 53s ⏱️ - 2m 0s Results for commit b548a66. ± Comparison against base commit d989b73. This pull request removes 2 tests. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa92eef01c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| [workspace.package] | ||
| version = "1.7.1-dev" | ||
| version = "1.8.0-dev" |
There was a problem hiding this comment.
Raise the compatibility floor before writing v2 WAL records
With the workspace version advanced to 1.8, this change starts emitting v2 envelopes from ingestion (for example Kafka now sends envelope.into_raw() at crates/ingress-kafka/src/consumer_task.rs:538). The cluster marker still advertises min_forward_compatible_version as 1.6.0 in COMPATIBILITY_INFORMATION and writes that value whenever max_version advances (crates/types/src/cluster_marker.rs:36-39, crates/types/src/cluster_marker.rs:256-262), while v2 envelopes encode as StorageCodecKind::Custom (crates/wal-protocol/src/v2.rs:91-94) and the v1/flexbuffers decode path rejects unsupported codecs (crates/types/src/storage/decode.rs:24-31). After any ingested v2 record, a rollback or mixed-version reader that the marker still permits can fail reading the log; bump the marker or gate v2 writes until all readers are upgraded.
Useful? React with 👍 / 👎.
Switch the code paths that uses IngestionClient to start ingesting v2 Envelope instead of v1
Switch the code paths that uses IngestionClient to start ingesting
v2 Envelope instead of v1
Stack created with Sapling. Best reviewed with ReviewStack.
OutboxMessage#4989ingestionto use V2 #4980