Skip to content

envelope-v2: Move ingestion to use V2#4980

Open
muhamadazmy wants to merge 2 commits into
mainfrom
pr4980
Open

envelope-v2: Move ingestion to use V2#4980
muhamadazmy wants to merge 2 commits into
mainfrom
pr4980

Conversation

@muhamadazmy

@muhamadazmy muhamadazmy commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Switch the code paths that uses IngestionClient to start ingesting
v2 Envelope instead of v1


Stack created with Sapling. Best reviewed with ReviewStack.

@github-actions

Copy link
Copy Markdown

Test Results

  8 files  ±0    8 suites  ±0   2m 53s ⏱️ - 2m 0s
 59 tests  - 2   59 ✅  - 2  0 💤 ±0  0 ❌ ±0 
266 runs   - 2  266 ✅  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit b548a66. ± Comparison against base commit d989b73.

This pull request removes 2 tests.
dev.restate.sdktesting.tests.Custom ‑ run(CustomTestConfig, URI, URI)[1]
dev.restate.sdktesting.tests.ServiceToServiceScopeConcurrency ‑ scopeAndLimitKeyArePropagatedOnServiceToServiceCalls(URI, ContainerHandle, Client)

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

Test Results

  8 files  ±0    8 suites  ±0   5m 13s ⏱️ + 2m 6s
 61 tests +1   61 ✅ +1  0 💤 ±0  0 ❌ ±0 
268 runs  +1  268 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 96e6f02. ± Comparison against base commit 0578b00.

♻️ This comment has been updated with latest results.

Comment thread Cargo.toml
@muhamadazmy muhamadazmy marked this pull request as ready for review June 30, 2026 07:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa92eef01c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml

[workspace.package]
version = "1.7.1-dev"
version = "1.8.0-dev"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Raise the compatibility floor before writing v2 WAL records

With the workspace version advanced to 1.8, this change starts emitting v2 envelopes from ingestion (for example Kafka now sends envelope.into_raw() at crates/ingress-kafka/src/consumer_task.rs:538). The cluster marker still advertises min_forward_compatible_version as 1.6.0 in COMPATIBILITY_INFORMATION and writes that value whenever max_version advances (crates/types/src/cluster_marker.rs:36-39, crates/types/src/cluster_marker.rs:256-262), while v2 envelopes encode as StorageCodecKind::Custom (crates/wal-protocol/src/v2.rs:91-94) and the v1/flexbuffers decode path rejects unsupported codecs (crates/types/src/storage/decode.rs:24-31). After any ingested v2 record, a rollback or mixed-version reader that the marker still permits can fail reading the log; bump the marker or gate v2 writes until all readers are upgraded.

Useful? React with 👍 / 👎.

Switch the code paths that uses IngestionClient to start ingesting
v2 Envelope instead of v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants