[RESTEASY-3073] Account for comments when parsing service loader files#3004
Merged
jamezp merged 1 commit intoresteasy:mainfrom Jan 7, 2022
Merged
[RESTEASY-3073] Account for comments when parsing service loader files#3004jamezp merged 1 commit intoresteasy:mainfrom
jamezp merged 1 commit intoresteasy:mainfrom
Conversation
RESTEasy includes its own parser of service loader files (in the `RegisterBuiltin` class). That parser doesn't account for comments, even though those are legal (see [1]). That makes for some interesting error messages when using e.g. RESTEasy's support for MicroProfile Context Propagation, because that file does use comments [2]. [1] https://docs.oracle.com/javase/9/docs/api/java/util/ServiceLoader.html [2] https://github.com/resteasy/resteasy-microprofile/blob/main/context-propagation/src/main/resources/META-INF/services/jakarta.ws.rs.ext.Providers
jamezp
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RESTEasy includes its own parser of service loader files (in the
RegisterBuiltinclass). That parser doesn't account for comments,even though those are legal (see [1]). That makes for some interesting
error messages when using e.g. RESTEasy's support for MicroProfile
Context Propagation, because that file does use comments [2].
[1] https://docs.oracle.com/javase/9/docs/api/java/util/ServiceLoader.html
[2] https://github.com/resteasy/resteasy-microprofile/blob/main/context-propagation/src/main/resources/META-INF/services/jakarta.ws.rs.ext.Providers