local: Fix fd leak when encountering files directly inside data/#3568
Merged
rawtaz merged 1 commit intorestic:masterfrom Nov 7, 2021
Merged
local: Fix fd leak when encountering files directly inside data/#3568rawtaz merged 1 commit intorestic:masterfrom
rawtaz merged 1 commit intorestic:masterfrom
Conversation
rawtaz
approved these changes
Nov 7, 2021
Contributor
rawtaz
left a comment
rawtaz
left a comment
There was a problem hiding this comment.
As it should be, splendid find.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
restic currently leaks file descriptors when listing a
data/folder which directly contains files instead of in the subfolders. This PR adds the missing call toClose().Was the change previously discussed in an issue or on the forum?
https://forum.restic.net/t/too-many-open-files/4503/12
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.