toJSON and toString #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonutEspresso
force-pushed
the
tostring
branch
from
7ad1d58 to
d5602b4
Compare
DonutEspresso
force-pushed
the
tostring
branch
2 times, most recently
from
6f63784 to
234add6
Compare
Member
Author
|
If all looks good, let's get this merged. |
lib/index.js
Outdated
Contributor
There was a problem hiding this comment.
Probably should check for capital or lowercase Error
Contributor
|
LGTM |
DonutEspresso
force-pushed
the
tostring
branch
2 times, most recently
from
6fc775f to
5fb8e0f
Compare
Member
Author
|
Addressed comments - final pass and I'll get it merged. @yunong FYI |
Member
Author
|
Gonna merge this sometime today, I think this will require a major rev due to changes in the |
DonutEspresso
force-pushed
the
tostring
branch
from
5fb8e0f to
754c15b
Compare
- add toJSON and toString methods - rev nsp. allow nsp to output success message - update travis build targets - normalize all code and restCode properties
DonutEspresso
force-pushed
the
tostring
branch
from
754c15b to
bb39d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement these two methods for better stand alone formatting (see restify/node-restify#952).
Also fixes some inconsistencies in the stringified output with regards to having 'Error' at the end of the code.