Skip to content

use verror cause() method instead of inspecting internal props #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonutEspresso merged 1 commit into from
Aug 17, 2016
Merged

use verror cause() method instead of inspecting internal props #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"coveralls": "^2.11.4",
"eslint": "^3.0.1",
"istanbul": "^0.4.2",
"jscs": "^3.0.7",
"jscs": "^2.11.0",
"mkdirp": "^0.5.1",
"mocha": "^2.3.4",
"nsp": "^2.2.0",
Expand All @@ -53,6 +53,6 @@
"dependencies": {
"assert-plus": "^1.0.0",
"lodash": "^4.2.1",
"verror": "^1.6.0"
"verror": "^1.8.1"
}
}
16 changes: 8 additions & 8 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ describe('restify-errors node module.', function() {
var priorErr = new Error('foobar');
var myErr = new HttpError(priorErr, 'new message');

assert.equal(myErr.we_cause, priorErr);
assert.equal(myErr.cause(), priorErr);
assert.equal(myErr.name, 'HttpError');
assert.equal(myErr.message, 'new message');
assert.isObject(myErr.body);
Expand All @@ -81,7 +81,7 @@ describe('restify-errors node module.', function() {
message: myErr2Msg
});

assert.equal(myErr2.we_cause, priorErr);
assert.equal(myErr2.cause(), priorErr);
assert.equal(myErr2.name, 'HttpError');
assert.equal(myErr2.message, myErr2Msg);
assert.isObject(myErr2.body);
Expand Down Expand Up @@ -145,7 +145,7 @@ describe('restify-errors node module.', function() {
var priorErr = new Error('foobar');
var myErr = new httpErrors.BadGatewayError(priorErr);

assert.equal(myErr.we_cause, priorErr);
assert.equal(myErr.cause(), priorErr);
assert.equal(myErr.name, 'BadGatewayError');
assert.equal(myErr.statusCode, 502);
assert.isObject(myErr.body);
Expand All @@ -157,7 +157,7 @@ describe('restify-errors node module.', function() {
message: myErr2Msg
});

assert.equal(myErr.we_cause, priorErr);
assert.equal(myErr.cause(), priorErr);
assert.equal(myErr2.name, 'BadGatewayError');
assert.equal(myErr2.statusCode, 502);
assert.equal(myErr2.message, myErr2Msg);
Expand Down Expand Up @@ -218,7 +218,7 @@ describe('restify-errors node module.', function() {
var priorErr = new Error('foobar');
var myErr = new RestError(priorErr);

assert.equal(myErr.we_cause, priorErr);
assert.equal(myErr.cause(), priorErr);
assert.equal(myErr.name, 'RestError');
assert.equal(myErr.restCode, 'Error');
assert.equal(myErr.message, '');
Expand All @@ -233,7 +233,7 @@ describe('restify-errors node module.', function() {
};
var myErr2 = new RestError(priorErr, options);

assert.equal(myErr2.we_cause, priorErr);
assert.equal(myErr2.cause(), priorErr);
assert.equal(myErr2.name, 'RestError');
assert.equal(myErr2.restCode, options.restCode);
assert.equal(myErr2.message, options.message);
Expand Down Expand Up @@ -549,7 +549,7 @@ describe('restify-errors node module.', function() {
assert.isObject(err.body);
assert.equal(err.body.code, 'Execution');
assert.equal(err.body.message, 'bad joystick input');
assert.equal(err.we_cause, underlyingErr);
assert.equal(err.cause(), underlyingErr);

// assert stringification
assert.equal(JSON.stringify(err), JSON.stringify({
Expand Down Expand Up @@ -584,7 +584,7 @@ describe('restify-errors node module.', function() {
assert.isObject(err.body);
assert.equal(err.body.code, 'Execution');
assert.equal(err.body.message, 'bad joystick input');
assert.equal(err.we_cause, underlyingErr);
assert.equal(err.cause(), underlyingErr);
assert.equal(err.context.foo, 'bar');
assert.deepEqual(err.context.baz, [1,2,3]);

Expand Down