Skip to content

add serializers for verror.info and verror.MultiError#54

Merged
DonutEspresso merged 2 commits intomasterfrom
verror-info-multierr
Sep 2, 2016
Merged

add serializers for verror.info and verror.MultiError#54
DonutEspresso merged 2 commits intomasterfrom
verror-info-multierr

Conversation

@DonutEspresso
Copy link
Copy Markdown
Member

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 31, 2016

Coverage Status

Coverage decreased (-0.3%) to 97.748% when pulling ef899df on verror-info-multierr into 584f836 on master.

@DonutEspresso
Copy link
Copy Markdown
Member Author

Now that TritonDataCenter/node-verror#10 has landed, let's add some serializers for stuff that's directly using VError.

At some point in the next major release we should remove the context logic within this module, and use VError's info property instead.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 31, 2016

Coverage Status

Coverage increased (+0.2%) to 98.174% when pulling 032d2a3 on verror-info-multierr into 584f836 on master.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 31, 2016

Coverage Status

Coverage increased (+0.2%) to 98.174% when pulling 1f3be5b on verror-info-multierr into 584f836 on master.

@micahr
Copy link
Copy Markdown
Contributor

micahr commented Aug 31, 2016

LGTM

@DonutEspresso
Copy link
Copy Markdown
Member Author

BTW @yunong if you wanna try this out just copy pasta this:

var verror = require('verror');
var bunyan = require('bunyan');
var restifyErrors = require('restify-errors');

var log = bunyan.createLogger({
    name: 'logger',
    serializers: {
        err: restifyErrors.bunyanSerializer
    }
});

var underlyingErr = new Error('boom');
var multiErr = new verror.MultiError([
    new Error('boom'),
    new restifyErrors.InternalServerError(underlyingErr, {
        message: 'wrapped',
        context: {
            foo: 'bar',
            baz: 1
        }
    })
]);

log.error(multiErr, 'oh noes');

Once we're completely on VError's new features we can break the serializer out into its own module. Need some catchy names that don't take forever to type (require('bunyan-verror-serializer')).

@DonutEspresso DonutEspresso merged commit 3a8712a into master Sep 2, 2016
@sean3z sean3z deleted the verror-info-multierr branch September 12, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants