-
Notifications
You must be signed in to change notification settings - Fork 30
Upgraded all dependencies #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…`.message`; so tests pass once more.
1 similar comment
|
LGTM |
|
@SamuelMarks could you list all the other PRs that this will close? |
|
Thanks @SamuelMarks! Can you provide some context on the changes to the tests? I'm curious which updated dependency caused them to fail? |
|
Any news about that? |
|
I'm not sure @DonutEspresso; I tend to just update all dependencies and tests until they all pass. |
|
@SamuelMarks I brought your PR down locally - I think the breakage is actually due to a bug in the existing tests. The tests were doing a It appeared the existing tests were doing a deepEqual but actually passing an incorrect reference. Let me know if you have the time to make the changes! Otherwise, I can take your work here and run with it. 👍 Appreciate the help! |
|
@DonutEspresso It's a good idea to commit the |
|
@SamuelMarks @DonutEspresso I've opened a PR with the fix: |
|
@simonepri Looks great! If you are able to open up a PR against this repo, I can merge it in. |
Fix test suite
1 similar comment
|
Thank you @SamuelMarks @simonepri! Appreciate the help in getting this over the finish line. Apologies for this taking so long! |
Changed
new Errorobject tests to check.message; so tests pass once more.