Wrap request/response instead of hacking the prototype

[mcavage]

No need to do what we're doing right now, as it doesn't play nice with express.

[mcavage]

meh, not fixing.

[tjarratt]

If you're making changes to request/response 's prototype, doesn't that mean you could conflict with other libraries that do the same thing? I realize that using express with restify is probably something no sane person should ever do, but I could imagine a scenario, say, where a testrunner for several projects (some of which use Restify, some of which use Express) would run into problems because different tests would require express and restify and mess up the prototype.

Full disclosure: the "hypothetical" scenario described above is actually a problem I'm currently trying to solve.

[mcavage]

Yes, it does. Unfortunately, this is the cost of v8. Once upon a time, I
did the "right thing" and wrapped it all, using getters/setters on the
properties. restify was 15-20 times slower than now (a trivial echo
server peaked at about 250-300 requests/second). So the short is, it's
lame, and it sucks, but it is what it is, and this just what it has to be
:.

On Thu, May 2, 2013 at 5:38 PM, Tim Jarratt notifications@github.comwrote:

If you're making changes to request/response 's prototype, doesn't that
mean you could conflict with other libraries that do the same thing? I
realize that using express with restify is probably something no sane
person should ever do, but I could imagine a scenario, say, where a
testrunner for several projects (some of which use Restify, some of which
use Express) would run into problems because different tests would require
express and restify and mess up the prototype.

Full disclosure: the "hypothetical" scenario described above is actually a
problem I'm currently trying to solve.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-17373368
.