Restify errors#844
Merged
DonutEspresso merged 3 commits intomasterfrom Aug 25, 2015
Merged
Conversation
Member
Author
|
Seems like older versions of npm don't like the https dependency in package.json. Guess we'll wait to publish restify-errors, if possible. |
DonutEspresso
force-pushed
the
restify-errors
branch
2 times, most recently
from
5515563 to
fd9bd9e
Compare
Member
Author
|
@yunong this looks good to go - if you have pub rights for restify-errors, once that's up I can change this from a git url to the actual version. |
Contributor
|
Can you please add a CHANGES.md to the errors repo? |
DonutEspresso
force-pushed
the
restify-errors
branch
from
fd9bd9e to
386830a
Compare
Member
Author
|
LGTM, now. Merge unless you have any other requests. |
Contributor
|
Looks good. Feel free to merge. On Monday, August 24, 2015, Alex Liu notifications@github.com wrote:
Via mobile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New errors module, all broken out from core. Not ready for merging, yet, but want a place to stage the diff and discuss potential impact to restify core.