move plugins into their own repo. #978
Merged
DonutEspresso merged 1 commit into5.xfrom Dec 29, 2015
Merged
Conversation
Member
Author
|
Waiting on restify/plugins#8 |
DonutEspresso
force-pushed
the
plugins
branch
3 times, most recently
from
9b3843c to
ae0c21f
Compare
Member
Author
|
Looks like we're good to go. PTAL |
Contributor
There was a problem hiding this comment.
Curious why clients is both a dev and normal dependency, shouldn't normal dependency win out?
Member
Author
There was a problem hiding this comment.
Def unintentional - will fix.
Member
Author
There was a problem hiding this comment.
Looks like clients and plugins are used only for tests, so I've moved them to dev deps.
DonutEspresso
force-pushed
the
plugins
branch
from
ae0c21f to
089176c
Compare
Contributor
|
LGTM |
DonutEspresso
force-pushed
the
plugins
branch
from
089176c to
c116d31
Compare
DonutEspresso
added a commit
that referenced
this pull request
Dec 29, 2015
move plugins into their own repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORS gets to stay since router uses it.