2.7 1485 reference parsing issues#1507
Merged
Merged
Conversation
thboileau
force-pushed
the
2.7_1485_reference_parsing_issues
branch
from
5f2d97b to
23412fe
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses Restlet issue #1485 by tightening Reference parsing/validation so malformed schemes and authorities (notably around IPv6 and userinfo/host ambiguity) are detected earlier, and by expanding test coverage for these failure modes.
Changes:
- Add scheme and authority validation in
Reference(including IPv6 + embedded IPv4 tail checks) and adjust parsing around query/path boundary cases. - Extend
ReferenceTestCasewith new negative tests for malformed hosts/schemes and additional parsing edge cases. - Minor formatting/header updates in unrelated files.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
org.restlet/src/main/java/org/restlet/data/Reference.java |
Adds authority/scheme validation and adjusts parsing logic (query vs path; IPv6/IPv4-tail validation). |
org.restlet/src/test/java/org/restlet/data/ReferenceTestCase.java |
Adds/adjusts tests for invalid authorities/schemes and edge-case parsing behaviors. |
org.restlet/src/main/java/org/restlet/resource/ClientResource.java |
Updates copyright year. |
org.restlet.ext.freemarker/src/test/java/org/restlet/ext/freemarker/FreeMarkerTestCase.java |
Formatting-only change for Configuration initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jlouvel
approved these changes
May 29, 2026
thboileau
force-pushed
the
2.7_1485_reference_parsing_issues
branch
from
755cae5 to
4a69450
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim
Fix parsing of Reference instances as reported in ticket 1485
Check-list
DO NOT REVIEW