Refine SIP session timer negotiation behavior#198
Merged
shenjinti merged 1 commit intorestsend:mainfrom Apr 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_timerswitch from a newsession_timer_alwaysoptionalwaysmode when a successful refresh response omitsSession-ExpiresWhy
The previous implementation mixed negotiated and forced session-timer behavior behind one flag, which made it hard to match PJPROJECT semantics. It also had a caller-leg bug in
alwaysmode: when the peer replied to a refresh withoutSession-Expires, the code forced the refresher touacunconditionally, which could flip ownership to the remote side on the inbound leg and stop further local refreshes.Impact
session_timer=truekeeps the normal negotiated behaviorsession_timer_always=trueforces PJPROJECT-style always behavior without usingRequire: timeralwaysmodeValidation
cargo test test_session_timer_mode -- --nocapturecargo test session_timer -- --nocapturecargo test apply_refresh_response -- --nocapturecargo test test_init_callee_timer_disabled_without_session_expires -- --nocapture