NullReferenceException for body parameters that don't have a name

[stodolos]

Expected Behavior

I would not have to add a name, or the error message would be clearer that a parameter name was missing.

Actual Behavior

A NullReferenceException is thrown.

Steps to Reproduce the Problem

1. Add a request body parameter without a name

This must be the issue in RestClient.ConfigureHttp (it's assuming the name is there):

var parameterExists =
                    request.Parameters.Any(p =>
                        p.Name.Equals(defaultParameter.Name, StringComparison.InvariantCultureIgnoreCase)
                        && p.Type == defaultParameter.Type);

Specifications

• Version: 106.6.9.0
• Platform: .NET Framework
• Subsystem:

StackTrace

System.NullReferenceException: Object reference not set to an instance of an object. at RestSharp.RestClient.<>c__DisplayClass172_0.b__8(Parameter p) at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate) at RestSharp.RestClient.ConfigureHttp(IRestRequest request) at RestSharp.RestClient.ExecuteAsync(IRestRequest request, Action`2 callback, String httpMethod, Func`4 getWebRequest) at RestSharp.RestClient.ExecuteAsync(IRestRequest request, Action`2 callback, Method httpMethod)

[alexeyzimarev]

@vbenedichuk any reason why you don't want to submit a PR?

[alexeyzimarev]

Closed in the next release. Breaking change!

[mitcht]

I was attempting to debug / fix a problem but found that your change introduced a bug. See line

RestSharp/RestSharp/RestRequest.cs

Line 335 in a8a9f34

AddParameter(new JsonParameter("", obj));

You'll see that the line is newing up an object but not providing a name required by validation:

RestSharp/RestSharp/Parameter.cs

Lines 28 to 35 in a8a9f34

	public Parameter(string name, object value, ParameterType type)
	{
	Ensure.NotEmpty(name, nameof(name));
	Name = name;
	Value = value;
	Type = type;
	}

RestSharp/RestSharp/Validation/Ensure.cs

Lines 13 to 17 in a8a9f34

	public static void NotEmpty(string parameter, string name)
	{
	if (string.IsNullOrWhiteSpace(parameter))
	throw new ArgumentNullException(name);
	}

Submitted pull request:
#1337

[alexeyzimarev]

Seems like we are missing some tests. Indeed body parameters don't need a name. I think a better fix would only check if the name is not empty for parameters that aren't of type body.

[mitcht]

I updated the pull request to reflect your idea.

[mitcht]

I only caught this issue because I was trying to understand RestSharp better. It doesn't seem to be an issue in the nuget package at this time.

[alexeyzimarev]

Yeah, the new version isn't published yet. I made some more changes in preparation to move to better async handling and also to address some of the issues with exceptions handling

[MKI-Miro]

when it will be fixed?