Skip to content

Conversation

@jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Feb 6, 2025

Description

Looking into the documentation on handling responses, I found a note on IsSuccessfulStatusCode mentioning "that 404 response code means succes". However, when checking implementation and tests, I found only that ResponseStatus will be Completed on 404 responses, but IsSuccessfulStatusCode should be false.

See also:

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@alexeyzimarev alexeyzimarev merged commit e35ffd8 into restsharp:dev Sep 11, 2025
1 check passed
@jnoordsij jnoordsij deleted the patch-1 branch September 11, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants