Restore 2-param AddCookie(name, value) overload#2351
Merged
alexeyzimarev merged 2 commits intodevfrom Feb 26, 2026
Merged
Conversation
PR #1966 replaced the simple AddCookie(name, value) with a 4-param overload requiring domain upfront, breaking the public API. This restores the 2-param form by deferring domain resolution to execution time using CookieContainer.Add(Uri, Cookie). - Add _cookies pending list and PendingCookies accessor to RestRequest - Add AddCookie(name, value) extension that stores cookies for deferred resolution alongside the existing 4-param AddCookie overload - Resolve pending cookies at execution time in RestClient.Async.cs using the request URL to infer domain - Update cookie documentation across all doc versions to show both forms - Fix Cookes typo in docs Closes #2284 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Review Summary by QodoRestore 2-param AddCookie overload and fix documentation
WalkthroughsDescription• Restore 2-parameter AddCookie(name, value) overload for backward compatibility • Defer domain resolution to execution time using CookieContainer.Add(Uri, Cookie) • Add pending cookies list to RestRequest following existing _files pattern • Update documentation across all versions with both simple and explicit forms • Fix Cookes typo to Cookies in documentation Diagramflowchart LR
A["AddCookie(name, value)"] --> B["Create Cookie object"]
B --> C["Store in _cookies list"]
C --> D["ExecuteRequestAsync"]
D --> E["Resolve domain from URL"]
E --> F["Add to CookieContainer"]
G["AddCookie(name, value, path, domain)"] --> F
File Changes1. src/RestSharp/Request/RestRequest.cs
|
Contributor
Code Review by Qodo
1.
|
Deploying restsharp with
|
| Latest commit: |
38c5e32
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe50fb40.restsharp.pages.dev |
| Branch Preview URL: | https://feature-restore-addcookie-2p.restsharp.pages.dev |
Contributor
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Test Results 26 files 26 suites 13m 22s ⏱️ Results for commit 9c040c2. |
- Wrap cookieContainer.Add in try/catch for CookieException, matching the existing pattern in CookieContainerExtensions.AddCookies - Clear pending cookies after transfer to avoid duplicate adds on request retry/reuse - Make PendingCookies public so BeforeRequest interceptors and authenticators can observe cookies added via the 2-param overload - Clarify docs: 4-param AddCookie populates CookieContainer immediately, 2-param stores in PendingCookies until execution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddCookie(name, value)overload that was removed in PR Move Cookie handling out of HttpClient so we do not cross pollinate requests #1966 when cookies were refactored to useCookieContainerCookieContainer.Add(Uri, Cookie), which infers the domain from the request URL_cookiespending list toRestRequest(following the existing_filespattern) with pending cookies resolved inExecuteRequestAsyncbefore building headersCookestypo →Cookiesin docsTest plan
CookieTestspass across all 4 target frameworks (net10.0, net9.0, net8.0, net48)AddCookie("name", "value")sends cookie with domain inferred from URLAddCookie("name", "value", "/", "domain")still works as beforeCloses #2284
🤖 Generated with Claude Code