Fix problem with overriding request defaults #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code could override the http.Timeout with the value of 0 if the RestClient Timeout property was 0. If RestClient.Timeout <= 0, it shouldn't override the http.Timeout.
If a user overrides the IHttpFactory, RestCLient shouldn't overwrite the default user agent with its own unless both the RestClient and the Http instance both have not set the user agent to a proper value.
|
Just added another commit to this PR. In this case, my user agent was being over-written by the This also has a slight optimization in that the old code was using reflection against the assembly every time a new instance was created to determine the version. That's not going to change over the lifetime of the AppDomain so calculate it once and be done. :) |
petejohanson
added a commit
that referenced
this pull request
Aug 6, 2012
Fix problem with overriding request defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all! It's me again.
The code I replaced was the following line:
Note that if
request.Timeoutandthis.Timeoutare both0, this code would sethttp.Timeoutto0, overriding whatever value it might have been already.What? "
http.Timeoutis by default0so this is a noop?" you say?In the immortal words of Bart Simpson, au contraire, mon frère! You can't know that. RestSharp provides an extensibility point via the
HttpFactoryproperty ofRestClientwhich allows you to substitute your ownIHttpFactory.This is how I found the issue because I overrode the
IHttpFactoryso that I could supply some defaults universally - whether I'm using an instance ofRestClientorHttpto make the request.This pull request makes it so you simply don't set the property unless the
Timeoutof the request or theRestClientis greater than0.