Fix problem with overriding request defaults #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all! It's me again.
The code I replaced was the following line:
Note that if
request.Timeout
andthis.Timeout
are both0
, this code would sethttp.Timeout
to0
, overriding whatever value it might have been already.What? "
http.Timeout
is by default0
so this is a noop?" you say?In the immortal words of Bart Simpson, au contraire, mon frère! You can't know that. RestSharp provides an extensibility point via the
HttpFactory
property ofRestClient
which allows you to substitute your ownIHttpFactory
.This is how I found the issue because I overrode the
IHttpFactory
so that I could supply some defaults universally - whether I'm using an instance ofRestClient
orHttp
to make the request.This pull request makes it so you simply don't set the property unless the
Timeout
of the request or theRestClient
is greater than0
.