Host resolution Support #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One known issue with this is the output still displays the IP, not the domain, even if a domain is provided. I will probably go back through and fix this, probably adding ip-only output as an option in case people are chaining armada to tools that don't support host resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds domain name resolution to armada using the standard library
(String, u16).to_socket_addrs()function. The README has been updated to show the new behavior.I decided to add the resolution to armada instead of armada_lib because this change was super simple and adding it to armada lib seemed like it would be much more complex and have breaking changes, and any libraries using armada_lib can add resolution themselves somewhat easily.
Also included in this PR is the removal of the deprecated
rand::thread_rng().gen_range(), replacing it with the updatedrand::random_range()function.Closes #2