Release as JS Package

[reteps]

Similar to https://github.com/mvdan/sh/tree/master/_js, this should be released as a javascript package so that it can be used with prettier.

[JounQin]

Can you add browser entry like https://github.com/un-ts/sh-syntax/blob/main/src/browser.ts

https://github.com/un-ts/sh-syntax/tree/main?tab=readme-ov-file#api

[reteps]

@JounQin I added a getWasmModule hook -- will that be sufficient for your needs?

[reteps]

Or are you asking for a module export in package.json for ESM support?

[JounQin]

@JounQin I added a getWasmModule hook -- will that be sufficient for your needs?

import fs from 'node:fs/promises';

@reteps It won't work on browser. A new entry for browser is needed.

[reteps]

I see -- I'll make a separate import.

[reteps]

Hi @JounQin -- I have moved all Node specific imports behind an isNode guard and have inlined the imports. I am not sure if it now works for the browser.

[JounQin]

require will be broken because is ESM format.

I still recommend you split into two entries with exports, like

[JounQin]

Maybe I can help to cooperate on this repo?

[reteps]

That would be excellent. Is there really no way to have a single ESM module that works for both node and browser environments? If the issue is commonJS, I can play around with it some more to get a ESM.

In any case, I'll take any PR that isn't duplicating a lot of code.

[JounQin]

Before:

FROM node:lts-alpine          as       builder

# 安装与编译代码
COPY        .      /app
WORKDIR         /app
RUN yarn           --frozen-lockfile &&            \
    yarn       build &&           \
    find . -name      '*.map' -type f -exec rm -f {} \;

# 最终的应用
FROM          abiosoft/caddy
COPY --from=builder          /app/packages/ufc-host-app/build /srv
EXPOSE      2015

After:

FROM node:lts-alpine          as       builder

# 安装与编译代码
COPY . /app
WORKDIR         /app
RUN yarn           --frozen-lockfile &&            \
    yarn       build &&           \
    find . -name      '*.map' -type f -exec rm -f {} \;

# 最终的应用
FROM          abiosoft/caddy
COPY --from=builder /app/packages/ufc-host-app/build /srv
EXPOSE      2015

Is that expected? @reteps

Test script:

import { formatDockerfile } from '@reteps/dockerfmt'

console.log(
  await formatDockerfile('packages/sh/test/fixtures/Dockerfile', {
    indent: 2,
    trailingNewline: true,
  }),
)

[reteps]

@JounQin I just made a new release that should fix all of those bugs. Thank you!

[reteps]

Released JS in 0.2.5 alongside those fixes.

[JounQin]

@JounQin I just made a new release that should fix all of those bugs. Thank you!

I didn't see any changes in un-ts/prettier#433, related tests

https://github.com/un-ts/prettier/blob/c0d68a96b0d921bb5d642ceb9c489d8cf0cd9619/packages/sh/test/fixtures.spec.ts#L38-L53

May bad, I just return instead of continue wrong.

[reteps]

Great! If you notice any further issues, feel free to file another one on the repo.