Skip to content

Shouldm #263

@thinkong

Description

@thinkong

Shouldn't RunWrite defer close()?

func (t Term) RunWrite(s *Session, optArgs ...RunOpts) (WriteResponse, error) {
    var response WriteResponse

    res, err := t.Run(s, optArgs...)
    if err != nil {
        return response, err
    }

    if err = res.One(&response); err != nil {
        return response, err
    }

    if err = res.Close(); err != nil {
        return response, err
    }

    if response.Errors > 0 {
        return response, fmt.Errorf(response.FirstError)
    }

    return response, nil
}

The code for runwrite I have is this...
I was thinking maybe it should be

func (t Term) RunWrite(s *Session, optArgs ...RunOpts) (WriteResponse, error) {
    var response WriteResponse

    res, err := t.Run(s, optArgs...)
    if err != nil {
        return response, err
    }

    if err = res.One(&response); err != nil {
        return response, err
    }
        defer res.Close()
//  if err = res.Close(); err != nil {
//      return response, err
//  }

    if response.Errors > 0 {
        return response, fmt.Errorf(response.FirstError)
    }

    return response, nil
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions