Skip to content

Conversation

@NotJustAnna
Copy link
Member

Reason for the change
Release a hotfix to partial sequences and adds shutdown reasons to the response pump, which should help debug a later issue.

Description
Result.java code related to partial sequences was moved out to a inner class.

Code examples
No code changes.

Checklist

References
None.

@NotJustAnna
Copy link
Member Author

I don't understand why the tests fails, to be honest. Running locally works just fine.

@NotJustAnna NotJustAnna requested a review from gabor-boros June 3, 2020 21:11
@martinpaljak
Copy link

FYI: there is still a hang with partials (the test that directly calls .toList() hang intermittently).

I'll deploy it to see what the exception with pumps is.

@NotJustAnna
Copy link
Member Author

.toList() hanging? Lemme see. Did I break aggressive fetch mode?

@gabor-boros gabor-boros merged commit 01b17f8 into master Jun 4, 2020
@gabor-boros gabor-boros deleted the release-candidate/2.4.3-hotfixes branch June 4, 2020 15:58
@martinpaljak
Copy link

@NotJustAnna
Copy link
Member Author

Lol what? That's really confusing.

@NotJustAnna
Copy link
Member Author

Uhh.. I'll try solve this with Boros once we can. (cc @gabor-boros)

Something on our publish routine is publishing the old version binaries with the new ones.

  • v2.4.3 folder contains v2.4.3 and v2.4.2
  • v2.4.4 folder contains v2.4.4, v2.4.3 and v2.4.2

@gabor-boros
Copy link
Member

Hell. I guess it’s that I forgot to remove the previous versions before deploy. I’ll redeploy the affected versions tomorrow

@gabor-boros
Copy link
Member

If that’s possible

@martinpaljak
Copy link

"mvn clean deploy" or whatever is the equivalent with gradle should be the standard procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants