Prototype code for /mail to get sent via Discord #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grassboii
reviewed
Nov 2, 2024
Grassboii
previously approved these changes
Nov 2, 2024
Member
|
Works on local server. It might be good to return a help case if discord is applied in the regular command ie. |
Garsooon
previously approved these changes
Oct 14, 2025
Member
Garsooon
left a comment
Garsooon
left a comment
There was a problem hiding this comment.
see previous comment for what I think might be beneficial
# Conflicts: # Essentials/pom.xml # EssentialsChat/pom.xml # EssentialsGeoIP/pom.xml # EssentialsProtect/pom.xml # EssentialsSpawn/pom.xml # pom.xml
Improves the Discord mail forwarding feature by: - Ensuring mail forwarding only occurs if both Discord plugins are enabled. - Preventing forwarding to online players. - Preventing forwarding to players who have disabled the feature. - Adds logging for successful and failed Discord mail attempts. - Fixes a typo in the UserData class that was preventing UUID's being set correctly.
RhysB
added a commit
that referenced
this pull request
Oct 24, 2025
* Stop players /ignore'ing staff JPerms groups * Update trial helper group name * Refactors ignore command for staff exemption Changes the ignore command to use the `essentials.ignore.exempt` permission instead of relying on JPerms for staff identification. This allows admins to easily configure staff members who cannot be ignored, regardless of their group membership. Also, ensures that exempted players are automatically unignored by all other players upon joining. * Code for /mail to get sent via Discord (#11) * Prototype code for /mail to get sent via Discord * Remove ] * Resolve stale pr conflicts * Versioning * Fix merge error * Enhances Discord mail integration Improves the Discord mail forwarding feature by: - Ensuring mail forwarding only occurs if both Discord plugins are enabled. - Preventing forwarding to online players. - Preventing forwarding to players who have disabled the feature. - Adds logging for successful and failed Discord mail attempts. - Fixes a typo in the UserData class that was preventing UUID's being set correctly. --------- Co-authored-by: Garsooon <carson12345678910@hotmail.com> Co-authored-by: Garsooon <46406077+Garsooon@users.noreply.github.com> * Resolve build issues * Stop players /ignore'ing staff JPerms groups * Update trial helper group name * Refactors ignore command for staff exemption Changes the ignore command to use the `essentials.ignore.exempt` permission instead of relying on JPerms for staff identification. This allows admins to easily configure staff members who cannot be ignored, regardless of their group membership. Also, ensures that exempted players are automatically unignored by all other players upon joining. * Make ignore check occur earlier --------- Co-authored-by: Rhys B <jetpackingwolf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.