Add an option to allow an user to change VNC settings#112
Merged
retspen merged 2 commits intoretspen:masterfrom Jul 11, 2016
Merged
Add an option to allow an user to change VNC settings#112retspen merged 2 commits intoretspen:masterfrom
retspen merged 2 commits intoretspen:masterfrom
Conversation
Else a user without these permission could delete or resize and instance by forging a good post request.
Contributor
Author
|
Is there something wrong with this pull requests ? |
Owner
|
Good job. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also correct a security bug: permission where not checked before resize or delete and just the web form were changed.
fix #107