Skip to content

localhost should be direct accessed too#134

Closed
balthild wants to merge 2 commits intoretspen:masterfrom
balthild:master
Closed

localhost should be direct accessed too#134
balthild wants to merge 2 commits intoretspen:masterfrom
balthild:master

Conversation

@balthild
Copy link
Copy Markdown

I'm sure it's a bug...

@balthild
Copy link
Copy Markdown
Author

balthild commented Apr 22, 2017

Oh I made a mistake too.
localhost should be direct accessed, but a remote host must be tunneled.
So we should change re.match('^127\.', console_host) to !re.match('^127\.', console_host) instead of removing it.

@QDaniel
Copy link
Copy Markdown
Contributor

QDaniel commented Jun 26, 2020

This is not a bug, is a feature.

The GUI can run on a other host as the VM. If you have multiple computes and this are public servers then you must set the vNC listen adress to 127.0.0.1 and make a ssh tunnel to the compute-host.

If you set the listen adress to "All Interfaces" then this is a big security hole. And everybody has full access to your machines.

@W0rmsy
Copy link
Copy Markdown

W0rmsy commented Jun 26, 2020

Hello, is this linked to #309 ?
would be awesome, it can solve the issue :)

@balthild
Copy link
Copy Markdown
Author

Well... I remember the reason that I thought it's a bug is, the noVNC connection fails with the condition re.match('^127\.', console_host). But I had not considered the security problem at that time. So the connection failure is intended, and I should configure the tunnel elsewhere to get noVNC work properly?

@balthild balthild closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants