New Features: Add/Remove CD-Rom Device, Enchance VM Creation #208
Merged
retspen merged 25 commits intoretspen:masterfrom Dec 18, 2018
Merged
New Features: Add/Remove CD-Rom Device, Enchance VM Creation #208retspen merged 25 commits intoretspen:masterfrom
retspen merged 25 commits intoretspen:masterfrom
Conversation
…ns statement for actions
…e that, instance creation gets all images of all pools. If there is a problem with some pools other than default. It causes problem and sometimes it takes too long to opeen create instance page. With that extension getting volumes is up to request. Firs you must select pool then select volume. For now the create page opens instantly.
…e unnecessary control while detaching the disk
…ice for custom instance creation. Change some cosmetics on create instance. Change some functions signature for compatibility. Add getting disk device types function. Fixed some bugs
…bus selection for disk. add device selection for disk. Some ui changes.
Owner
|
Thank you. Good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Retspen,
If it is appropriate please accept it. Thanks.
Major Changes:
3.1. Add disk type selection.
3.2. Get volumes list with ajax. it provides speed.
3.3. Select storage to add volume. it provides clearity
3.4. Add disk type/bus select options
3.5. Add qemu-guest-agent option while creating instance.