Skip to content

fix for dhcp fixed address#220

Merged
retspen merged 11 commits intoretspen:masterfrom
catborise:master
Jan 28, 2019
Merged

fix for dhcp fixed address#220
retspen merged 11 commits intoretspen:masterfrom
catborise:master

Conversation

@catborise
Copy link
Copy Markdown
Collaborator

Hi retspen,

There are two bugs about fixed address and suspend/poweroff operations
we should merge it to solve that.

thanks.

@lord-kyron
Copy link
Copy Markdown
Contributor

@catborise
I found something not working as expected.
Example:
Creating new filter from inside existing filter (go inside existing filter and press the green + button on the top right):
image
As you can see from the screenshot - the input box is moved to the left and I can see only the half of it.
Please, fix it when you can! :)

@catborise
Copy link
Copy Markdown
Collaborator Author

@Bandic007 thanks bandic. i forgot to remove it. It is unnecessary in filter details. i remove it and i align the buttons.

@lord-kyron
Copy link
Copy Markdown
Contributor

Yes, it is looking great now! Thank you!

@lord-kyron
Copy link
Copy Markdown
Contributor

lord-kyron commented Jan 25, 2019

@catborise - something got wrong here.
Now in the network page, where you added the function to add more fixed addresses there is a XML show filed, to see the network config. But when I press the "Show button" to see the fixed addresses, it is not showing this filed, but it opens again the XML field from above.
image
Can you check and fix it?

@lord-kyron
Copy link
Copy Markdown
Contributor

lord-kyron commented Jan 25, 2019

@catborise - I've actually found the issue and fixed it in my deployment.
Lines 164 and 168 in /networks/templates/network.html - #collapseOne must be change on both places with #collapseTwo and it is fixed :)
Please, apply it in the repo too

@catborise
Copy link
Copy Markdown
Collaborator Author

@Bandic007 nice catch. there are two collapsible...

@retspen
Copy link
Copy Markdown
Owner

retspen commented Jan 28, 2019

Thank you!

@retspen retspen merged commit aea7545 into retspen:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants