Skip to content

Max length increased and public port#260

Merged
retspen merged 4 commits intoretspen:masterfrom
busyrack:master
Nov 20, 2019
Merged

Max length increased and public port#260
retspen merged 4 commits intoretspen:masterfrom
busyrack:master

Conversation

@t-tran
Copy link
Copy Markdown
Contributor

@t-tran t-tran commented Nov 17, 2019

  • Updat max length in a bunch of places to 64 chars
  • Add setting WS_PUBLIC_PORT to support this running behind a reverse proxy such as nginx+ssl

@lord-kyron
Copy link
Copy Markdown
Contributor

@t-tran - what config should I use on the nginx when reverse-proxying to webvirtcloud with enabled websocket public port? At the moment I am doing this almost the same way, but I also have ws_public_path which is '/novncd/' and in nginx I am proxying this specific location to localhost:6080 in order to work. Can you give and example config or explain how is it supposed to work your way?

@t-tran
Copy link
Copy Markdown
Contributor Author

t-tran commented Nov 18, 2019

Hi @lord-kyron, I'm running reverse-proxy + SSL on standard https port 443 which has nginx config looks like this:

upstream novnc_server {
    server back.end.server.ip:6080;
}

server {
    listen 443 ssl;
    listen [::]:443 ssl;
    location /websockify {
        proxy_http_version 1.1;
        proxy_pass http://novnc_server/;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
        proxy_read_timeout 61s;
        proxy_buffering off;
    }

Since the frontend port (443) is different from backend port (6080). I need this setting so it routes correctly.

@lord-kyron
Copy link
Copy Markdown
Contributor

Thank you! Working like a charm now!

@retspen
Copy link
Copy Markdown
Owner

retspen commented Nov 20, 2019

Thank you!

@retspen retspen merged commit 68107ae into retspen:master Nov 20, 2019
@lord-kyron
Copy link
Copy Markdown
Contributor

lord-kyron commented Nov 20, 2019

@t-tran do you have exprience with several compute nodes? For example will vnc work if I try to open the console on a VM which is on another compute node, different from the one that webvirtcloud is installed, but added as compute in the web interface? Should I open 6080 port on this compute or?

@catborise
Copy link
Copy Markdown
Collaborator

Hi @lord-kyron, I'm running reverse-proxy + SSL on standard https port 443 which has nginx config looks like this:

upstream novnc_server {
    server back.end.server.ip:6080;
}

server {
    listen 443 ssl;
    listen [::]:443 ssl;
    location /websockify {
        proxy_http_version 1.1;
        proxy_pass http://novnc_server/;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
        proxy_read_timeout 61s;
        proxy_buffering off;
    }

Since the frontend port (443) is different from backend port (6080). I need this setting so it routes correctly.
@t-tran
could you please prepare a wiki page for reverse-proxy. it could be useful for ones who have to use that.
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants