Fix Port configuration for novncd#352
Merged
retspen merged 1 commit intoretspen:masterfrom Aug 18, 2020
shokinn:fix_novncd_port
Merged
Fix Port configuration for novncd#352retspen merged 1 commit intoretspen:masterfrom shokinn:fix_novncd_port
retspen merged 1 commit intoretspen:masterfrom
shokinn:fix_novncd_port
Conversation
Reverte accidentally change variable for novncd port configuration. Change variable `WS_PUBLIC_PORT` back to `WS_PORT`
Merged
Owner
|
Hello, I'm not sure about that changes. WS_PUBLIC_PORT variable need for fronted side and use for redirect or URL open. |
Contributor
|
@retspen - this is not a change but a fix as in the last commit @catborise changed this in the wrong place and VNC stopped working for us. That is why @shokinn is reverting this back as we tested it and that was the problem. |
Contributor
Author
|
Yupp. @retspen See discussion here: #343 (comment) |
Owner
|
I understood. Thanks for help! |
Contributor
|
@shokinn - you can join the official Webvirtcloud Discord channel here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert accidentally change variable for novncd port configuration.
Change variable
WS_PUBLIC_PORTback toWS_PORT