Merged
Conversation
Collaborator
|
It is a standart Kvm ethernet MAC prefix. It should not be problem. This prefix defines that Ethernet is a Kvm vm Ethernet. But your suggestion does not Break anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the hard coded MAC OUI in the code and instead fetches the OUI from settings.py
If independent instances of WebVirtCloud (or any libvirt) exists on the same subnet and VMs are configured to use a bridge interface, this could lead to duplicate MACs on the same subnet (low probability, but still possible).
This change gives the user a choice to define an OUI.