for rbd devices, evaluate name field for graceful error message#202
Merged
retspen merged 1 commit intoretspen:masterfrom Jan 26, 2014
Merged
for rbd devices, evaluate name field for graceful error message#202retspen merged 1 commit intoretspen:masterfrom
retspen merged 1 commit intoretspen:masterfrom
Conversation
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
Owner
|
Thanks! |
retspen
added a commit
that referenced
this pull request
Jan 26, 2014
for rbd devices, evaluate name field for graceful error message
dhamaniasad
pushed a commit
to dhamaniasad/webvirtmgr
that referenced
this pull request
Mar 18, 2014
for rbd devices, evaluate name field for graceful error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using rbd devices such as:
Viewing the instance configuration causes a 500, as disk.xpathEval('source/@file|source/@dev')[0] throws an index error as one might expect. If we use the name field to lookup the storage volume, the instance view is displayed, however a graceful error is displayed:
https://drive.google.com/file/d/0B9DbsE2BbZ7uQzlrSEZBbG1UUnM/edit?usp=sharing
Signed-off-by: Tyler Baker tyler.baker@linaro.org