Skip to content

for rbd devices, evaluate name field for graceful error message#202

Merged
retspen merged 1 commit intoretspen:masterfrom
EmbeddedAndroid:master
Jan 26, 2014
Merged

for rbd devices, evaluate name field for graceful error message#202
retspen merged 1 commit intoretspen:masterfrom
EmbeddedAndroid:master

Conversation

@EmbeddedAndroid
Copy link
Copy Markdown
Contributor

When using rbd devices such as:

<disk type='network' device='disk'>
  <driver name='qemu' type='raw'/>
  <auth username='libvirt'>
    <secret type='ceph' uuid='dc28392e-a277-4077-80ed-07040f5daffb'/>
  </auth>
  <source protocol='rbd' name='data/controller'>
    <host name='compute01' port='6789'/>
    <host name='192.168.1.2' port='6789'/>
  </source>
  <target dev='vdz' bus='virtio'/>
  <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
</disk>

Viewing the instance configuration causes a 500, as disk.xpathEval('source/@file|source/@dev')[0] throws an index error as one might expect. If we use the name field to lookup the storage volume, the instance view is displayed, however a graceful error is displayed:

https://drive.google.com/file/d/0B9DbsE2BbZ7uQzlrSEZBbG1UUnM/edit?usp=sharing

Signed-off-by: Tyler Baker tyler.baker@linaro.org

Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
@retspen
Copy link
Copy Markdown
Owner

retspen commented Jan 26, 2014

Thanks!

retspen added a commit that referenced this pull request Jan 26, 2014
for rbd devices, evaluate name field for graceful error message
@retspen retspen merged commit 6ebfcbc into retspen:master Jan 26, 2014
dhamaniasad pushed a commit to dhamaniasad/webvirtmgr that referenced this pull request Mar 18, 2014
for rbd devices, evaluate name field for graceful error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants