Add VNC keymap support and allow password clear#293
Merged
retspen merged 3 commits intoretspen:masterfrom Apr 26, 2014
Merged
Conversation
Owner
|
Thanks! Nice work. |
retspen
added a commit
that referenced
this pull request
Apr 26, 2014
Add VNC keymap support and allow password clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I just added support for setting vnc keymap (as also requested by #140) and added the functionality to clear the vnc password. No real big changes, just an improvement in vrtManager/instance.py:wvmInstance.set_vnc_passwd. The old implementation used regex to manipulate the xml, I now use ElementTree, this is less messy and was needed so that you can set and reset password and keymap independently (other setting was deleted every time).
Hope you like it, this is my first pull request on github :)
btw: webvirtmgr is awesome!