Skip to content

Add RPM spec file and Upstart file. Fix novnc in console#495

Merged
retspen merged 2 commits intoretspen:masterfrom
edospadoni:master
Jan 29, 2015
Merged

Add RPM spec file and Upstart file. Fix novnc in console#495
retspen merged 2 commits intoretspen:masterfrom
edospadoni:master

Conversation

@edospadoni
Copy link
Copy Markdown
Contributor

No description provided.

@edospadoni
Copy link
Copy Markdown
Contributor Author

The file conf/init/webvirtmgr-redhat.conf is only in my branch, as you can see on my pull request the file is marked as new. Include the file in your repo then build rpm again.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this Django package is coming from? (pip, EPEL rpm?), because in https://github.com/retspen/webvirtmgr/blob/master/requirements.txt version is 1.5.5 (but this should not be a problem); just be careful that you are coupling this script to a specific version of Django, in a specific path. In this case I will add a comment.
BTW, everything is in /usr/lib/python2.6/site-packages/ should be already in the PYTHONPATH, or I'm wrong?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rpm works with EPEL package without any additional extra packages like pip. The versions are the same required in requirements.txt, I tested with version 1.5.6 and it works great. Anyway you fell free to add comment.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the target is CentOS 6 using EPEL then LGTM

Thanks for clarification!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome! :)
The RPM is designed to work on cleaned RedHat-like system (RHEL, CentOS) installations. If you add EPEL repo, you have all tools necessary to work with ease.

retspen added a commit that referenced this pull request Jan 29, 2015
Add RPM spec file and Upstart file. Fix novnc in console
@retspen retspen merged commit ef0a294 into retspen:master Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants