fix: validate the stored language before using it (detectLang)#25
Open
Mubashirrrr wants to merge 1 commit into
Open
fix: validate the stored language before using it (detectLang)#25Mubashirrrr wants to merge 1 commit into
Mubashirrrr wants to merge 1 commit into
Conversation
detectLang() validates the URL-hash language against ['en','ko','ja'] but returns the localStorage value unchecked. A stale/invalid `harness-lang` value would be handed to setLang(), which then no-ops every translation lookup (leaving the page in English with no active language button) instead of falling through to the navigator-language / 'en' default. Validate the stored value the same way the hash path does. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
detectLang()validates the URL-hash language but trusts thelocalStoragevalue unchecked, so a stale/invalid stored value leaves the page silently stuck in English.Why
If
harness-langever holds a value outsideen|ko|ja(a future rename, a stale key, etc.),detectLangreturns it, andsetLangthen fails everyi18n[key][lang]lookup — leaving all text in English with no active language button — instead of falling through to thenavigator.language/'en'default.Fix
Validate the stored value against the same allowed set as the hash path:
Small consistency/robustness fix; makes both code paths agree.
🤖 Generated with Claude Code