Merged
Conversation
There was a problem hiding this comment.
4 issues found across 8 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/__tests__/replace-dependencies.spec.ts">
<violation number="1" location="src/__tests__/replace-dependencies.spec.ts:243">
P2: The assertion contradicts the test intent: it expects the function name to be replaced. If function names should not be treated as dependencies, this should assert the original function name remains unchanged.</violation>
</file>
<file name="README.md">
<violation number="1" location="README.md:57">
P2: The new README examples call `parseFormula` without importing it, so the snippet won't run when copied. Add `parseFormula` to the imports in these examples.</violation>
</file>
<file name="src/ohm/core/serialize-ast.ts">
<violation number="1" location="src/ohm/core/serialize-ast.ts:58">
P2: String escaping is incomplete - newlines, tabs, and other control characters in `node.value` will not be escaped, potentially producing invalid output.</violation>
<violation number="2" location="src/ohm/core/serialize-ast.ts:100">
P1: `serializeTernaryChild` doesn't wrap nested ternary expressions, causing incorrect serialization. An AST like `(a ? b : c) ? d : e` would serialize to `a ? b : c ? d : e`, which parses with different associativity.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary by cubic
Adds serializeAst and replaceDependencies to convert ASTs back to expression strings and remap dependency paths, enabling safer refactors and tooling. Updates exports, docs, and tests.
Written for commit 7508b05. Summary will update on new commits. Review in cubic