Skip to content

chore: Repo hygiene and small lint fixes#262

Merged
rfivesix merged 1 commit intodevelopfrom
jules-16748737886149666533-0469a8d0
Apr 13, 2026
Merged

chore: Repo hygiene and small lint fixes#262
rfivesix merged 1 commit intodevelopfrom
jules-16748737886149666533-0469a8d0

Conversation

@rfivesix
Copy link
Copy Markdown
Owner

This PR addresses a few small codebase hygiene issues identified via static analysis.
Fixes include:

  • Complying with curly_braces_in_flow_control_structures in profile_screen.dart.
  • Removing unnecessary braces in string interpolation in sleep_week_overview_page.dart.
  • Removing an unused field in pr_dashboard_screen.dart and an unused constructor in analytics_state.dart.
  • Simplifying an unnecessarily wrapped getter/setter in sleep_day_view_model.dart.

PR created automatically by Jules for task 16748737886149666533 started by @rfivesix

- Added missing curly braces to else if block in profile_screen.dart
- Removed unnecessary string interpolation in sleep_week_overview_page.dart
- Removed unused _topMomentumIndex in pr_dashboard_screen.dart
- Removed unused constructor AnalyticsState._
- Simplified scope field in SleepPeriodSelection

Co-authored-by: rfivesix <232375389+rfivesix@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies small repo-hygiene fixes driven by static analysis/lints across profile, sleep, and analytics UI/state code.

Changes:

  • Fixes missing curly braces in profile_screen.dart flow control to satisfy curly_braces_in_flow_control_structures.
  • Simplifies minor style issues (string interpolation braces, unused members/constructors).
  • Streamlines SleepPeriodSelection by removing a redundant private backing field/getter/setter layer.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/screens/profile_screen.dart Adds required braces to else if branches for lint compliance.
lib/screens/analytics/pr_dashboard_screen.dart Removes an unused constant from the dashboard state.
lib/features/statistics/domain/analytics_state.dart Removes an unused private constructor from AnalyticsState.
lib/features/sleep/presentation/week/sleep_week_overview_page.dart Simplifies string interpolation in tick label formatting.
lib/features/sleep/presentation/day/sleep_day_view_model.dart Simplifies SleepPeriodSelection by using a direct scope field and updating internal switches.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Owner Author

@rfivesix rfivesix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rfivesix rfivesix merged commit ad452ec into develop Apr 13, 2026
8 checks passed
@rfivesix rfivesix deleted the jules-16748737886149666533-0469a8d0 branch April 15, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants