Skip to content

Added more language definitions and expanded capabilities#1

Merged
rfritz merged 12 commits intorfritz:masterfrom
ghfbsd:master
Dec 29, 2023
Merged

Added more language definitions and expanded capabilities#1
rfritz merged 12 commits intorfritz:masterfrom
ghfbsd:master

Conversation

@ghfbsd
Copy link
Contributor

@ghfbsd ghfbsd commented Dec 24, 2023

These changes add vgrind prettyprint support for two more languages: Fortran 77 and R.

For R support, since the language allows . characters in identifiers, the changes add a new capability to flag this language feature.

Changes to filter mode permit suppressing of the procedure titles in the program listing.

Changed caveats about filter mode in documentation and listed another bug.

Also added "const" keyword to C language definition.

rfritz
rfritz previously approved these changes Dec 27, 2023
Copy link
Owner

@rfritz rfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another language supported! Great!

@rfritz rfritz dismissed their stale review December 27, 2023 04:34

Misunderstood github

@rfritz
Copy link
Owner

rfritz commented Dec 27, 2023

Thanks for all these changes - I'm surprised anyone else is interested in this venerable command. I'm going to think these over and get back to you. Most of them I like; the .gitignore change bothers me, and I think I'd rather be able to see ^Ms in my code - or are you working with programs that are brought over from Windows?

@ghfbsd
Copy link
Contributor Author

ghfbsd commented Dec 27, 2023

Firstly, thanks for reviving this tool on the mac.

Reason for changes: I need vgrind filter mode to list some code in an academic ms I'm writing. I used to use it years ago and it still has occasional usefulness.

Regarding ^M: Modern compilers accept either unix or windows style line endings. For the 1% of code that actually has ^M in a string/char constant somewhere, the change will cause it to disappear; but for the > 50% of code (most is developed on windows) that gets prettyprinted on this vgrind, the user will benefit. (One of them is me because I collaborate on code maintained on windows.) It seemed pointless adding a command line option to choose ignoring ^M rather than this simpler change that will work in 99% of use cases.

Regarding .gitignore: Live and let live. I don't like or plan on using CMake, so this is a mutual coexistence truce - view the proposed change in that spirit!

@rfritz
Copy link
Owner

rfritz commented Dec 28, 2023

Mmmm. That sounds reasonable. I'll be away tomorrow, so I'll probably check this in on Friday.

@rfritz rfritz merged commit d133daa into rfritz:master Dec 29, 2023
@rfritz
Copy link
Owner

rfritz commented Dec 30, 2023

And, it's checked in. I'm working on a Homebrew package manager formula for this -- if you're interested, I'll let you know when it's ready.

@rfritz
Copy link
Owner

rfritz commented Dec 30, 2023

And…here's the Homebrew formula; just add the rfritz/misc tap, and do "brew install vgrind".

Putting this to bed, I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants