fix: general fixes and cleanups

Author: paralin

src/client.spec.ts

@@ -57,7 +57,7 @@ query myQuery($age: Int) {
     client.setTransport(mt);
     let msgs: IRGQLServerMessage[] = [
       {mutateValue: {valueNodeId: 1, queryNodeId: 1, isArray: true}},
-      {mutateValue: {valueNodeId: 4, queryNodeId: 1, parentValueNodeId: 1}},
+      {mutateValue: {valueNodeId: 4, queryNodeId: 1, parentValueNodeId: 1, arrayIdx: 1}},
       {
         mutateValue: {
           valueNodeId: 5,

src/query-tree/query-tree.spec.ts

@@ -126,4 +126,27 @@ describe('QueryTreeNode', () => {
     let res = tree.children[0].children[0].fullPathPlain;
     expect(res).toEqual(['allPeople', 'name']);
   });
+
+  it('should detect differing arguments', () => {
+    let ast = parse(
+`
+query myQuery {
+field(arg1: "Test") {
+  subfield
+}
+}
+query mySecondQuery {
+field(arg1: "Test Two") {
+  subfield
+}
+}
+`,
+    );
+    let node = new QueryTreeNode();
+    let sel1 = (<any>ast.definitions[0]);
+    let sel2 = (<any>ast.definitions[1]);
+    let q1 = node.buildQuery(sel1, {});
+    let q2 = node.buildQuery(sel2, {});
+    expect(node.children.length).toBe(2);
+  });
 });

src/query.spec.ts

@@ -51,11 +51,11 @@ describe('ObservableQuery', () => {
     // However, due to debouncing we won't see the entire thing on the output without delays.
     let mutations: IRGQLValueMutation[] = [
       {valueNodeId: 1, queryNodeId: 1, isArray: true},
-      {valueNodeId: 4, parentValueNodeId: 1, queryNodeId: 1},
+      {valueNodeId: 4, parentValueNodeId: 1, queryNodeId: 1, arrayIdx: 1},
       {valueNodeId: 5, parentValueNodeId: 4, queryNodeId: 2, valueJson: '"John"', hasValue: true},
-      {valueNodeId: 2, parentValueNodeId: 1, queryNodeId: 1},
+      {valueNodeId: 2, parentValueNodeId: 1, queryNodeId: 1, arrayIdx: 2},
       {valueNodeId: 6, parentValueNodeId: 2, queryNodeId: 2, valueJson: '"Jane"', hasValue: true},
-      {valueNodeId: 3, parentValueNodeId: 1, queryNodeId: 1},
+      {valueNodeId: 3, parentValueNodeId: 1, queryNodeId: 1, arrayIdx: 3},
       {valueNodeId: 7, parentValueNodeId: 3, queryNodeId: 2, valueJson: '"Bill"', hasValue: true},
       {valueNodeId: 5, parentValueNodeId: 4, queryNodeId: 2, operation: 2},
       {valueNodeId: 4, parentValueNodeId: 1, queryNodeId: 1, operation: 2},

src/sort/binary-insertion.spec.ts

@@ -17,19 +17,19 @@ describe('binary-insertion', () => {
     it('should return 1 for 4.5 -> [4, 5, 6, 7]', () => {
       expect(binarySearch([4, 5, 6, 7], 4.5)).toBe(1);
     });
-    fit('should splice 3 into [0, 1, 4, 5]', () => {
+    it('should splice 3 into [0, 1, 4, 5]', () => {
       let arr = [0, 1, 4, 5];
       let idx = binarySearch(arr, 3) + 1;
       arr.splice(idx, 0, 3);
       expect(arr).toEqual([0, 1, 3, 4, 5]);
     });
-    fit('should splice 3 into []', () => {
+    it('should splice 3 into []', () => {
       let arr: number[] = [];
       let idx = insertionIndex(arr, 3);
       arr.splice(idx, 0, 3);
       expect(arr).toEqual([3]);
     });
-    fit('should splice 3 into [5]', () => {
+    it('should splice 3 into [5]', () => {
       let arr: number[] = [5];
       let idx = insertionIndex(arr, 3);
       arr.splice(idx, 0, 3);