Skip to content

Replace glassfish with jackson#28

Merged
kornys merged 1 commit intorh-messaging:masterfrom
jirkadanek:jd_corny_json
Nov 29, 2017
Merged

Replace glassfish with jackson#28
kornys merged 1 commit intorh-messaging:masterfrom
jirkadanek:jd_corny_json

Conversation

@jirkadanek
Copy link

Glassfish is unable to encode a java.lang.Float type
to JSON. This seems trivial omission in the library,
easy to fix... Bug could be raised.

Jackson can encode it just fine. Seems a better choice.

This fixes #27

Glassfish is unable to encode a java.lang.Float type
to JSON. This seems trivial omission in the library,
easy to fix... Bug could be raised.

Jackson can encode it just fine. Seems a better choice.

This fixes rh-messaging#27
@codecov-io
Copy link

Codecov Report

Merging #28 into master will increase coverage by 0.04%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
+ Coverage     70.61%   70.66%   +0.04%     
  Complexity       81       81              
============================================
  Files            43       43              
  Lines          2049     2052       +3     
  Branches        293      293              
============================================
+ Hits           1447     1450       +3     
  Misses          467      467              
  Partials        135      135
Impacted Files Coverage Δ Complexity Δ
...main/java/com/redhat/mqe/lib/MessageFormatter.java 76.15% <60%> (-0.55%) 0 <0> (ø)
jmslib/src/main/java/com/redhat/mqe/lib/Utils.java 44.82% <0%> (+1.37%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db256b...3d2d2b2. Read the comment docs.

Copy link
Contributor

@kornys kornys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kornys kornys merged commit 5a1b018 into rh-messaging:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java.lang.Float is not supported when --log-msgs json is set

4 participants